[SDK-239] Fix dataset types #1262
Conversation
There was a problem hiding this comment.
Not sure we need Optional here... please see this too https://stackoverflow.com/questions/69440494/python-3-10-optionaltype-or-type-none#:~:text=Optional%20was%20invented%20to%20indicate,gets%20rid%20of%20an%20identifier.
There was a problem hiding this comment.
Also here we have a default None, so Optional is not required:
https://docs.python.org/3/library/typing.html#typing.Optional
|
mnoszczak
force-pushed
the
mno/sdk-239
branch
from
f179cbd to
5b9e6d4
Compare
| @@ -68,8 +68,8 @@ class Dataset(DbObject, Updateable, Deletable): | |||
|
|
|||
| def data_rows( | |||
| self, | |||
| from_cursor: str = None, | |||
| where: Comparison = None, | |||
| from_cursor: Optional[str] = None, | |||
There was a problem hiding this comment.
this is tricky, but correct change I believe, based on https://docs.python.org/3/library/typing.html#typing.Optional
Makes the types more correct